[Bug 735660] v4l2: fix new v4l2 code not working with certain devices (regression)

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sat Aug 30 06:36:25 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=735660
  GStreamer | gst-plugins-good | 1.4.1

--- Comment #23 from Hans de Goede <jwrdegoede at fedoraproject.org> 2014-08-30 13:36:20 UTC ---
(In reply to comment #22)
> > Maybe we should empty the atomic queue and deactivate the allocator even if freeing
> > buffers didn't work ?
> 
> Right, that is what my patch does by not setting ret to an error (AFAIK).

To be a bit more clear here, any queued buffers revert there ownership to
userspace on a streamoff, 
and they can be unmmap-ed at this time too. Actually the un-mmap must be done
before the reqbufs(0), otherwise it will fail with -EBUSY even if supported.

All the reqbufs(0) call does is free underlying kernel memory, which is why it
was not part of the original v4l2 api design, the thinking being that that
could wait till fd close.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.


More information about the gstreamer-bugs mailing list