[Bug 735660] v4l2: fix new v4l2 code not working with certain devices (regression)

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sat Aug 30 07:47:53 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=735660
  GStreamer | gst-plugins-good | 1.4.1

--- Comment #25 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-08-30 14:47:50 UTC ---
Seems fair, what I had in mind is that we should still do:

> allocator->count = 0;
> g_atomic_int_set (&allocator->active, FALSE);

If the reqbufs(0) failed. There is no reason other then having an old driver
for that call to fail, hence we can expect that these drivers to behave like
bttv. This will allow the pre-conditions to be met when _start() is called
later. Pre-conditions from gst_v4l2_allocator_start() are:

> g_return_val_if_fail (count != 0, 0);
> GST_OBJECT_LOCK (allocator);
> if (g_atomic_int_get (&allocator->active))
>   goto already_active;

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.


More information about the gstreamer-bugs mailing list