[Bug 733864] v4l2videodec: Implement EOS handling through V4L2_DEC_CMD_STOP

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=733864
  GStreamer | gst-plugins-good | git

Nicolas Dufresne (stormer) <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #293103|none                        |needs-work
             status|                            |

--- Comment #11 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> 2014-12-20 00:58:42 UTC ---
Review of attachment 293103:
 --> (https://bugzilla.gnome.org/review?bug=733864&attachment=293103)

::: sys/v4l2/gstv4l2bufferpool.c
@@ +1049,3 @@
+#ifndef V4L2_BUF_FLAG_LAST
+#define V4L2_BUF_FLAG_LAST                     0x00100000
+#endif

Hmm, I think it's a bit soon for this one, has there been a patch submitted ?

@@ +1078,3 @@

+  if (group->buffer.flags & V4L2_BUF_FLAG_LAST) {
+    goto eos_buffer;

The EOS buffer may have a payload. The current EOS buffer detection is
currently done in _process() method. We currently detect empty payload as being
EOS. The FLAG_LAST may or may not have a payload, hence require special
handling.

::: sys/v4l2/gstv4l2videodec.c
@@ +299,3 @@
   GST_DEBUG_OBJECT (self, "Finishing decoding");

+#if 1

The should not be there.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.