[Bug 721764] souphttpsrc: Add ability to do HTTP session logging

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=721764
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #266270|none                        |needs-work
             status|                            |

--- Comment #26 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-02-04 12:07:35 UTC ---
Review of attachment 266270:
 --> (https://bugzilla.gnome.org/review?bug=721764&attachment=266270)

::: ext/soup/gstsouphttpsrc.h
@@ +24,2 @@
 #include <libsoup/soup.h>
+#include "gstsouputils.h"

No need for the header here, only needed in the .c file

::: ext/soup/gstsouputils.c
@@ +50,3 @@
+       * log level to SoupLoggerLogLevel and it should be added
+       * as a case */
+      c = level + '0';

This will break in interesting ways for too high levels. Maybe add an assertion
here if level is too large, or use multiple characters. Or get the
SoupLoggerLogLevel nick from the GEnum and just always use that

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.