[Bug 722343] waylandsink: fix surface width/height when caps have changed

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=722343
  GStreamer | gst-plugins-bad | 1.x

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #267416|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-02-04 12:12:48 UTC ---
Review of attachment 267416:
 --> (https://bugzilla.gnome.org/review?bug=722343&attachment=267416)

Generally looks good. But it's not clear to me what happens if upstream just
ignores the reconfigure event and the new size will not be configured. What
will happen?

::: ext/wayland/gstwaylandsink.c
@@ +308,3 @@
+    caps = gst_caps_make_writable (caps);
+
+    /* There can only be a single structure because the xcontext

xcontext?

@@ +320,3 @@
+     * fixed width/height caps again if not possible
+     * upstream */
+    if (filter) {

Put the filter bit outside the "if (sink->window)" block at the very end and
just always do that

::: ext/wayland/gstwaylandsink.h
@@ +79,3 @@
   struct wl_callback *callback;
   guint redraw_pending :1;
+  gboolean reconfig_needed;

If you already use bitfields here, use them in a way that actually makes sense
;)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.