[Bug 722705] Factor out common init/reset code from matroska parse/demux

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Feb 4 04:35:26 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=722705
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #267679|none                        |accepted-commit_now
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-02-04 12:35:19 UTC ---
Review of attachment 267679:
 --> (https://bugzilla.gnome.org/review?bug=722705&attachment=267679)

Looks good but:

::: gst/matroska/matroska-read-common.c
@@ +2852,3 @@
+  if (ctx->global_tags) {
+    gst_tag_list_unref (ctx->global_tags);
+    ctx->global_tags = NULL;

Move this to reset() in a second commit

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.


More information about the gstreamer-bugs mailing list