[Bug 723741] New: segfault when clients disconnect

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=723741
  GStreamer | gst-rtsp-server | git

           Summary: segfault when clients disconnect
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-rtsp-server
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: ognyan.tonchev at axis.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=268258)
 View: https://bugzilla.gnome.org/attachment.cgi?id=268258
 Review: https://bugzilla.gnome.org/review?bug=723741&attachment=268258

thread-pool: Unref source after mainloop has quit to avoid races in GLib

gst_rtsp_thread_stop() triggers a race in GLib
(https://bugzilla.gnome.org/show_bug.cgi?id=720186) which causes trouble when
clients disconnect.
What happens is while the main loop is freed it also unreffs its context, at
the same time thread_stop() tries to unref the idle source which on the other
hand tries to lock the context mutex. But there is no guarantee that the
context pointer is valid since the source does not hold a ref to it.

The patch attached to this ticket implements a workaround for the GLib problem
in gst-rtsp-server. The source is now part of the ThreadImpl and it is unreffed
after the main loop quits.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.