[Bug 723492] gst-plugins-base: Do not build check tests for disabled plugins

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=723492
  GStreamer | gst-plugins-base | git

--- Comment #6 from Sebastian Rasmussen <sebras at hotmail.com> 2014-02-06 23:36:13 UTC ---
> Looks better but still... :)

yeah, yeah... I'll go over it one more time.
hopefully I'll learn from my mistakes and be
more careful when submitting the one for -good
again.

> ::: tests/check/Makefile.am
> @@ +182,1 @@
>      elements/audiotestsrc \
> 
> What about audiotestsrc?

Mmm, --disable-audiotestsrc is there so this one makes sense.
I'll fix it.

> @@ +209,3 @@
>      pipelines/simple-launch-lines \
>      pipelines/basetime \
>      pipelines/capsfilter-renegotiation \
> 
> Are the pipelines tests working properly if everything is disabled?

These ones are more doubtful. There a are no obivous --disable-basetime
(which depends on audiotestsrc and fakesink) or --disable-simple-launch-lines 
(which depends on alsasink, audioconvert, audioresample, audiotestsrc, 
capsfilter, fakesink, fakesrc, libvisual_lv_scope, tee, videoconvert, 
videoscale, videotestsrc and xvimagesink).

I spoke briefly with __tim on the subject and, as I understood him, the best 
approach is add ifdef-guards for complete check tests that obviously are
related 
to a specific plugin. For tests like basetime or simple-launch-lines where the
check test itself can not be obviously connected to any specific --disable-flag
then it might be better with a run-time approach. This would apply for any 
individual testcase where an element is created that is not in the plugin being
tested. To do this in run-time I think something along the lines of 
gst_element_factory_find() could be queried (most likely through some kind of 
convenience function, perhaps a tcase_add_with_dependencies()) and the tests 
skipped if any of those elements are missing.

Since this may require new convenience functions I believe that it would make
more sense to do those in a separate patch, and only go for disabling the check 
tests that can obviously be associated with a particular plugin in this patch.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.