[Bug 678301] audioringbuffer: introspection fixes and API clean up for bindings

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=678301
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #223669|none                        |needs-work
             status|                            |

--- Comment #19 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-02-08 13:46:32 UTC ---
Review of attachment 223669:
 --> (https://bugzilla.gnome.org/review?bug=678301&attachment=223669)

This needs to be a "_full" variant now

::: gst-libs/gst/audio/gstaudioringbuffer.c
@@ +675,3 @@

+  if (buf->cb_data_notify)
+    buf->cb_data_notify (buf->cb_data);

I think this needs to be in GObject::finalize() instead. It's not expected by
users of the ringbuffer to set a new callback and data whenever the ringbuffer
is released.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.