[Bug 724213] rtph264ay: shouldn't update time for sending SPS and PPS if we failed to send SPS or PPS
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Fri Feb 14 05:18:03 PST 2014
https://bugzilla.gnome.org/show_bug.cgi?id=724213
GStreamer | gst-plugins-good | unspecified
--- Comment #1 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2014-02-14 13:17:54 UTC ---
Looks sensible IMHO, although I'm not sure I understand the explanation
provided in the commit message. In what scenario do you get a non-OK flow
return here and why and how is it related to rtsp-server sending the config out
of band?
Some style nitpicks (sorry):
- typo: sucsess -> success (but maybe rename variable to "sent_all_sps_pps")
- move the variable declaration above guint i; (nicer alignment)
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list