[Bug 724638] aacparse : Missing resilience when no audio frame is found

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=724638
  GStreamer | gst-plugins-good | git

Thiago Sousa Santos <thiago.sousa.santos> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #269641|none                        |needs-work
             status|                            |

--- Comment #5 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2014-02-19 02:32:06 UTC ---
Review of attachment 269641:
 --> (https://bugzilla.gnome.org/review?bug=724638&attachment=269641)

::: gst/audioparsers/gstaacparse.c
@@ +390,3 @@
   *needed_data = 0;

+  if (G_UNLIKELY (avail < 6)) {

This should be moved into the if below as it only requires 6 bytes if it is
going to call _adts_get_frame_len.

So I'd suggest keeping the check for 2 bytes that is enough for the if below
and moving the check for 6 bytes inside the if.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.