[Bug 724571] In collectpads, the collected function is sometimes called incorrectly.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=724571
  GStreamer | gstreamer (core) | git

Stefan Sauer (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #269650|none                        |reviewed
             status|                            |

--- Comment #3 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2014-02-19 16:25:45 UTC ---
Review of attachment 269650:
 --> (https://bugzilla.gnome.org/review?bug=724571&attachment=269650)

::: tests/check/libs/collectpads.c
@@ +1040,3 @@
+  collected = FALSE;
+
+  gst_pad_push_event (srcpad1, gst_event_new_flush_stop (TRUE));

If these parts are independent, please split it into two tests.

@@ +1056,3 @@
+
+  /* Give a little time to make sure collected is not called */
+

meh. Can we do this differently?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.