[Bug 724638] aacparse : Missing resilience when no audio frame is found

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=724638
  GStreamer | gst-plugins-good | git

--- Comment #10 from Reynaldo H. Verdejo Pinochet <reynaldo at opendot.cl> 2014-02-19 17:05:25 UTC ---
(In reply to comment #8)
> (From update of attachment 269641 [details])
> >+  if (G_UNLIKELY (avail < 6)) {
> >+    *needed_data = 6 - avail;
> >     return FALSE;
> >+  }
> 
> Are you sure that's not supposed to be *needed_data = 6 ?

Hi Tim, thanks for your comment.

Yeah, it is. I got confused by the function's doc header:
..how much _more_ data is needed in the next round..

but after your comment, realized further up in the
calling tree this boils down to:

gst_base_parse_set_min_frame_size(..., needed_data)...

This also made me reconsider Thiago's comment for a different
reason: I shouldn't be setting needed_data if there isn't
at least some clue this might be an ADTS frame.

Patches updated & tested

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.