[Bug 724633] oggdemux: ignores last page in push mode

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=724633
  GStreamer | gst-plugins-base | 1.2.2

--- Comment #9 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2014-02-20 20:43:57 UTC ---
(In reply to comment #8)
> This whole 'do not read the last byte' thing to get the duration in push mode
> seems very fragile if not wrong to me. Why is this done again, so it doesn't do
> EOS stuff? If yes, we should maybe prevent that some other way, e.g. by adding
> a seek flag or so. The fix here with the SEEK_TYPE_SET, end=-1 is very
> unintuitive, and I'm sure it will get 'fixed' sooner or later ;)

The +1 at the beginning and -1 at the end are used to prevent libogg from
detecting a valid page and outputting something IIRC.

Yes, I agree this all sounds a bit ugly. We could likely track oggdemux own
seeks/segments using seqnums and use a segment query to restore the origial
segment afterwards.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.