[Bug 724638] aacparse : Missing resilience when no audio frame is found

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=724638
  GStreamer | gst-plugins-good | git

--- Comment #18 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2014-02-21 00:33:24 UTC ---
(From update of attachment 269705)
>+  gboolean crc_absent;

Turn that into a crc_size variable instead.

>+    /* Sampling frequency test */
>+    if (G_UNLIKELY ((data[2] & 0x3C) >> 2 == 15)) {
>+      GST_WARNING ("Invalid ADTS header: sampling frequency can't be 15");

Drop the GST_WARNING here please, seems a bit extreme just because we're not in
sync for some reason. Not sure we need a logging statement here at all.

>+    if ((*framesize < 9 && !crc_absent) || (*framesize < 7 && crc_absent)) {
>+      GST_WARNING ("Invalid ADTS header: framesize %d too small (HAS CRC: %s)",
>+          *framesize, crc_absent ? "No" : "Yes");
>+      return FALSE;
>+    }

Same as above, please get rid of the GST_WARNING (or demote to DEBUG if you
must keep it, but it's really just noise imho).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.