[Bug 724464] mpegts: does not check data sizes when parsing descriptors

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Feb 20 22:56:03 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=724464
  GStreamer | gst-plugins-bad | git

--- Comment #5 from Edward Hervey <bilboed at bilboed.com> 2014-02-21 07:16:43 UTC ---
Actually ... I'm wondering if all the following checks in descriptor parsing
shouldn't be moved to regular returns:

* descriptor presence (desc != NULL)
* non-empty descriptor (desc->data != NULL)
* correct descriptor type (desc->-tag == <expected descriptor type>)
* descriptor length (desc->length ...)

Maybe the first one can be kept as a g_return_val_if_fail (it's an argument),
but the others are all dependent on the data stream.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list