[Bug 724464] mpegts: does not check data sizes when parsing descriptors

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=724464
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #270136|none                        |reviewed
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-02-24 15:30:16 UTC ---
Review of attachment 270136:
 --> (https://bugzilla.gnome.org/review?bug=724464&attachment=270136)

::: gst-libs/gst/mpegts/gstmpegts-private.h
@@ +52,3 @@
+  ((desc)->data != NULL && (desc)->tag == (tagtype) && (desc)->length >=
(minlen))
+#define __common_desc_checks_exact(desc, tagtype, len)            \
+  ((desc)->data != NULL && (desc)->tag == (tagtype) && (desc)->length ==
(len))

I think these should be logged with GST_WARNING() or something

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.