[Bug 724893] playsinkconvertbin: improve gst_play_sink_convert_bin_getcaps return

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=724893
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #270101|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-02-25 09:02:41 UTC ---
Review of attachment 270101:
 --> (https://bugzilla.gnome.org/review?bug=724893&attachment=270101)

::: gst/playback/gstplaysinkconvertbin.c
@@ +395,3 @@
+              self->converter_caps, GST_CAPS_INTERSECT_FIRST);
+        }
+        ret = gst_caps_merge (peer_caps, converter_caps);

Why don't you use the macro here too?

@@ +406,3 @@
   } else {
     ret = gst_caps_new_any ();
+    GST_PLAY_SINK_CONVERT_BIN_FILTER_CAPS (filter, ret);

ret = filter ? gst_caps_ref (filter) : gst_caps_new_any ();

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.