[Bug 725227] New: gstegl / eglglessink: EGLImage improvements

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Feb 26 07:12:30 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=725227
  GStreamer | gst-plugins-bad | unspecified

           Summary: gstegl / eglglessink: EGLImage improvements
    Classification: Platform
           Product: GStreamer
           Version: unspecified
        OS/Version: Mac OS
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: julien.isorce at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=270398)
 --> (https://bugzilla.gnome.org/attachment.cgi?id=270398)
draft patch for A

Now that https://bugzilla.gnome.org/show_bug.cgi?id=706054 has been done, there
are still some improvements we can do before to move to gst-plugins-gl  (and
even before other improvements
https://bugzilla.gnome.org/show_bug.cgi?id=703343)

The improvements we can do in egllib / eglglessink are:

-A: refactor gst_egl_image_allocator_alloc_eglimage (
http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/ext/eglgles/gstegladaptation_egl.c#n426
)
Some part of the function should be moved from eglglessink to gstegl lib. Draft
patch will follow :p

-B: attach a GstVideoGLTextureUploadMeta to each buffer. The meta callback will
call everything around glEGLImageTargetTexture2DOES (i.e.
http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/ext/eglgles/gsteglglessink.c#n1369).
So that lines 1369 etc will be removed and line 1360 will be used instead.

A will allow to instantiate the GstEGLImageBufferPool in omxvideodec (through
gst_egl_image_buffer_pool_new (NULL, NULL, NULL), see draft patch for A) or
instantiate  GstEGLImageBufferPool in our external video sink directly. (ex:
webkitvideosink)

B will allow to use this code path
http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp#L329.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list