[Bug 724828] playbin: improve autoplug_query_caps return
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Wed Feb 26 11:56:00 PST 2014
https://bugzilla.gnome.org/show_bug.cgi?id=724828
GStreamer | gst-plugins-base | git
Sebastian Dröge (slomo) <slomo> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #270377|none |reviewed
status| |
--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-02-26 20:17:26 UTC ---
Review of attachment 270377:
--> (https://bugzilla.gnome.org/review?bug=724828&attachment=270377)
::: gst/playback/gstplaybin2.c
@@ +4697,3 @@
+
+ if (!n)
+ GST_PLAY_BIN_FILTER_CAPS (filter, result);
This does not make much sense to me. Why are you filtering "result" here? Where
does result come from and why isn't the filtering done there if necessary?
Everything else looks good.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list