[Bug 725341] playbin: detect if video-sink supports deinterlacing

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=725341
  GStreamer | gst-plugins-base | git

--- Comment #2 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-02-27 20:27:21 UTC ---
Review of attachment 270505:
 --> (https://bugzilla.gnome.org/review?bug=725341&attachment=270505)

Good PoC. Here's my list of missing:

- As you mention if there is subtitle and sink don't support it we are a bit
screwed, not sure how to detect that and fallback correctly
- Totem uses the flags to enable/disable interlacing, though with that solution
there is not mean to tell the sink not to de-interlace, at the same time I feel
like this option was there to let user see something even though they didn't
have a fast enough CPU. So mostly a relic. Even the worst de-interlacing looks
better then no-deinterlacing imho.

I'm open to discussion, though I personally like the idea of keeping it simple
like this PoC is doing.

::: gst/playback/gstplaysink.c
@@ +1499,3 @@
+    *ret |= TRUE;
+  } else {
+    *ret |= FALSE;

A bit too complex, just "*ret = TRUE" would do ;-P.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.