[Bug 721350] baseparse: push pending events before GAP

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=721350
  GStreamer | gstreamer (core) | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #265164|none                        |accepted-commit_now
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-02 17:14:57 UTC ---
Review of attachment 265164:
 --> (https://bugzilla.gnome.org/review?bug=721350&attachment=265164)

::: libs/gst/base/gstbaseparse.c
@@ +2017,3 @@
+    parse->priv->pending_events = NULL;
+    for (l = r; l != NULL; l = l->next) {
+      gst_pad_push_event (parse->srcpad, GST_EVENT (l->data));

Make this GST_EVENT_CAST() :)

@@ +2020,3 @@
+    }
+    g_list_free (r);
+    parse->priv->pending_segment = FALSE;

What is it good for? This variable seems useless or not properly used? :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.