[Bug 720692] audioringbuffer: track last position across release/acquire

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=720692
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #264494|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-03 09:41:32 UTC ---
Review of attachment 264494:
 --> (https://bugzilla.gnome.org/review?bug=720692&attachment=264494)

This looks generally good but

::: gst-libs/gst/audio/gstaudioringbuffer.c
@@ +691,3 @@
+  /* keep track of where were are in time, in case we get re-acquired */
+  buf->x.x.sample_base = gst_util_uint64_scale_round (buf->x.x.sample_counter,
+      GST_SECOND, buf->spec.info.rate);

This contains time for some time, and samples the remaining time. Please use
two different variables to make this clear and also mark the values as invalid
when they should not be used anymore

@@ +1600,2 @@
 done:
+  buf->x.x.sample_counter = *sample;

You never use the value stored in sample_counter.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.