[Bug 720661] audiobasesink: Fix locking bug accessing ring buffer time

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Jan 3 02:30:10 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=720661
  GStreamer | gst-plugins-base | unspecified

Vincent Penquerc'h <vincent.penquerch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vincent.penquerch at collabora
                   |                            |.co.uk

--- Comment #2 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> 2014-01-03 10:30:08 UTC ---
I think the audio sink would need to lock as a block a fair amount of the code
in gst_audio_base_sink_setcaps, which would mean the audio sink itself would
need adding lock/unlock calls (probably by adding
gst_audio_ring_buffer_{,un}lock APIs). This seems more complex, unless I'm not
seeing an easier way.
When locking at the base sink level, we already get this lock for free.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list