[Bug 720692] audioringbuffer: track last position across release/acquire

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=720692
  GStreamer | gst-plugins-base | unspecified

Vincent Penquerc'h <vincent.penquerch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vincent.penquerch at collabora
                   |                            |.co.uk

--- Comment #2 from Vincent Penquerc'h <vincent.penquerch at collabora.co.uk> 2014-01-03 10:50:23 UTC ---
Thanks for reviewing,

> This contains time for some time, and samples the remaining time. Please use
> two different variables to make this clear and also mark the values as invalid
> when they should not be used anymore

OK, fixed

>  done:
> +  buf->x.x.sample_counter = *sample;
> 
> You never use the value stored in sample_counter.

I do, it is used in gst_audio_ring_buffer_release (to convert to time).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.