[Bug 583890] v4l2: Implement V4L2_MEMORY_USERPTR support

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=583890
  GStreamer | gst-plugins-good | git

--- Comment #49 from Julien Isorce <julien.isorce at gmail.com> 2014-01-07 19:05:51 UTC ---
(In reply to comment #48)
> I finally success to play a video using your branch with v4l2sink using gst-omx
> buffers.

Cool!

> It's gst_base_sink_set_last_buffer_unlocked() which increase the refcount of
> the incoming buffer. So i disable the last-sample feature of the base sink
> (with enable-last-sample property).
> By doing so the incoming buffer has a refcount of one.

Ah nice catch.

> Also i found a little mistake in your code after "/* transfer userptr on the
> fly */" ( v4l2bufferpool.c:gst_buffer_pool_process() ):
> Whan the buffer doesn't contain meta. you call
> "gst_v4l2_buffer_pool_add_meta_helper (pool, to_queue);" but you don'"t assign
> the return value to meta. ie : it should be:
> 
> > if (!meta)
> >   meta = gst_v4l2_buffer_pool_add_meta_helper (pool, to_queue);

Thx. I reported it in one of my branch:
http://cgit.collabora.com/git/user/julien/gst-plugins-good.git/commit/?h=1.2-cc-delivery&id=bec4169411007bf3c745fb84168b9894c43044e2

I found a way to test this case, just doing videotestsrc ! v4l2sink userptr
It fallbacks to mmap but at least it reaches the code you mentioned.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.