[Bug 720568] v4l2: Various changes to allow using M2M decoders

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Jan 7 12:50:37 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=720568
  GStreamer | gst-plugins-good | git

--- Comment #55 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-01-07 20:50:29 UTC ---
(In reply to comment #46)
> (From update of attachment 264351 [details])
> The duration calculation should probably use the rounding variant of
> uint64_scale_int(). Also how is this supposed to work, it will cause
> accumulating rounding errors? Not a bug in this patch but looks wrong

This value is set at the buffer duration and for control bindings, same math is
used for latency calculation. We know that UVC camera lies on the framerate, we
can't really do anything about that. For latency we probably want a roundup
version, For buffer duration it will be wrong anyway, so unless we find another
solution there is nothing to do. For the controls bindings, I think we should
simply do this:

-      v4l2src->ctrl_time += v4l2src->duration;
+      v4l2src->ctrl_time = timestamp + v4l2src->duration;

But clearly this bug should be solved separately.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list