[Bug 704809] Use one GstGLContext per streaming thread

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=704809
  GStreamer | gst-plugins-gl | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #265391|none                        |reviewed
             status|                            |

--- Comment #16 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-08 09:36:04 UTC ---
Review of attachment 265391:
 --> (https://bugzilla.gnome.org/review?bug=704809&attachment=265391)

::: gst/gstquery.c
@@ +2610,3 @@
+ */
+gboolean
+gst_query_add_streaming_thread (GstQuery * query)

Maybe a different name to imply that it does not take a parameter for the
thread but adds the *current* thread

@@ +2626,3 @@
+  array =
+      ensure_array (structure, GST_QUARK (STREAMING_THREAD), sizeof
(gpointer),
+      (GDestroyNotify) NULL);

You probably want to use g_thread_ref/unref here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.