[Bug 720345] videobalance: handle unsupported caps features in passthrough mode

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=720345
  GStreamer | gst-plugins-good | git

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-08 09:38:40 UTC ---
(In reply to comment #5)
> (In reply to comment #2)
> > Review of attachment 264098 [details] [details]:
> > 
> > ::: gst/videofilter/gstvideobalance.c
> > @@ +77,3 @@
> > +
> > +#define VIDEOBALANCE_ALL_CAPS VIDEOBALANCE_CAPS ";" \
> > +    GST_VIDEO_CAPS_MAKE_WITH_FEATURES ("ANY", VIDEOBALANCE_VIDEO_FORMATS)
> > 
> > For this to all make any sense it would be good to implement support for every
> > video format, with the help of the pack/unpack functions from
> > GstVideoFormatInfo. Because why allow NV12/VASurface, but disallow
> > NV16/VASurface?
> 
> If you agree with it, i'll do that in separate.

Yes

> > 
> > And just doing passthrough on any unsupported video format will cause
> > unexpected behaviour. Maybe we also need a property to select this
> > auto-passthrough-if-unsupported mode?
> 
> The purpose is to make videobalance disable itself by default if it does not
> support the caps (and in particular the caps feature) to make hardware decoders
> work with playbin in the current situation, so I don't think a new property
> would be useful in this case.

It should be a new property IMHO, where the default is the current behaviour.
And playbin would set it to the behaviour your patch adds.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.