[Bug 679115] Windows: Make the GStreamer DLLs/data relocatable

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=679115
  GStreamer | gstreamer (core) | git

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-08 10:12:22 UTC ---
Thanks for updating the patch, just one comment then I think it can go in

(In reply to comment #5)

> > @@ +125,3 @@
> > +  return g_build_filename (
> > +    g_win32_get_package_installation_directory_of_module
> > (_priv_gst_dll_handle),
> > +    "lib",
> > 
> > If it is called lib or not depends on the parameters passed to configure, i.e.
> > --libdir. Could also be called anything else
> 
> I think this is the general convention that is used on Windows for the GTK+, so
> following suit here:)  This also applies to MSVC builds, which do not use
> configure to build.

I think you should use something from config.h for this, which is based on the
configure parameter. But it's probably ok as is

> > @@ +67,3 @@
> > +    g_win32_get_package_installation_directory_of_module
> > (_priv_gst_dll_handle),
> > +#ifdef _DEBUG
> > +    "debug",
> > 
> > Is this standard?
> 
> Nope, but I am following suit from the pre-generated config.h in win32/common. 
> We could always purge this part, if needed. :)

Sounds ok then :)

> > @@ +69,3 @@
> > +    "debug",
> > +#endif
> > +    "lib",
> > 
> > This one is in libexec, not lib. Also configurable with --libexecdir at
> > configure
> 
> Putting it here as "lib", as it is a helper.  Please advise if libexec is
> preferred to be set as something else. (perhaps with the other .exe's?)

libexec is for executables that are run by the library only and not meant for
users to run. bin should contain executables that the user should run
(gst-launch, etc)

This here should be the path where gst-plugin-scanner.exe is installed.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.