[Bug 720995] matroskamux: add g726 adpcm support

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=720995
  GStreamer | gst-plugins-good | 1.x

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #265683|none                        |needs-work
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-08 10:54:07 UTC ---
Review of attachment 265683:
 --> (https://bugzilla.gnome.org/review?bug=720995&attachment=265683)

I think we should make sure that a) the bitrate in riff-media is correctly
calculated for this case too, b) block_align is properly set there

::: gst-libs/gst/riff/riff-media.c
@@ +1398,3 @@
       caps = gst_caps_new_simple ("audio/x-adpcm",
+          "layout", G_TYPE_STRING, "g726", "bitrate", G_TYPE_INT,
+          strf->av_bps * 8, NULL);

and here check for strf!=NULL, and also strf->av_bps!=0. If we have no valid
bitrate we should fail muxing.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.