[Bug 720995] matroskamux: add g726 adpcm support

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=720995
  GStreamer | gst-plugins-good | 1.x

--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-08 11:25:15 UTC ---
(In reply to comment #12)
> thanks for the review, 
> 
> I'll work on the patch later today or this weekend, regarding the invalid
> bitrate and block align during mux, in the patch I sent for matroskamux
> actually we do these checks:
> 
> if (!gst_structure_get_int (structure, "block_align", &block_align)) {
>     GST_WARNING_OBJECT (mux, "Missing block_align on adpcm caps");
>     goto refuse_caps;
> }
> 
> if (!gst_structure_get_int (structure, "bitrate", &bitrate)) {
>     GST_WARNING_OBJECT (mux, "Missing bitrate on adpcm g726 caps");
>     goto refuse_caps;
> }
> 
> probably bitrate = 0 or block_align = 0 are invalid too, do you want I'll add
> these checks in matroskamux too? Probably the same considerations apply for
> others audio format in matroskamux, for example wma,

Yes, I think so too.

> additionally avenc_g726 seems to produce a wrong block_align (please try
> gst-launch-1.0 -v alsasrc ! avenc_g726 ! fakesink and see the output), for what
> I can understand block_align should be 1 for g726 audio, however I'm not 100%
> sure

I don't know either, sorry. But 0 seems wrong in any case :) That's the value
libav gives us though.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.