[Bug 721666] videodecoder: push newsegment earlier for reverse playback

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Jan 8 07:26:08 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=721666
  GStreamer | gst-plugins-base | unspecified

Thiago Sousa Santos <thiago.sousa.santos> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #265488|0                           |1
        is obsolete|                            |

--- Comment #3 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2014-01-08 15:26:01 UTC ---
Created an attachment (id=265711)
 View: https://bugzilla.gnome.org/attachment.cgi?id=265711
 Review: https://bugzilla.gnome.org/review?bug=721666&attachment=265711

videodecoder: use new segment earlier for reverse playback

For reverse playback, the segment event will only be pushed when
the first buffer is actually pushed. But for decoding frames and storing
those into the list to be pushed the output_segment.rate value is used
to determine if it is forward or reverse playback.

In case a previous segment event (or none) is in use it will mistakenly
think it is doing forward playback and push the buffers immediatelly and
try to clip buffers based on an old segment (or an uninitialized one, leading
to an assertion)

This patch fixes this by copying the segment earlier if on reverse playback

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list