[Bug 721807] souphttpsrc: expose SoupSocket

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=721807
  GStreamer | gst-plugins-good | unspecified

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #265766|none                        |needs-work
             status|                            |

--- Comment #3 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2014-01-08 22:36:35 UTC ---
Review of attachment 265766:
 --> (https://bugzilla.gnome.org/review?bug=721807&attachment=265766)

::: ext/soup/gstsouphttpsrc.c
@@ +751,3 @@
+
+  g_clear_object (&src->socket);
+  src->socket = g_object_ref (socket);

You have to either make the socket volatile and use g_atomic_int_set() here..
Or use GST_OBJECT_LOCK()/UNLOCK() to protect the socket everywhere.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.