[Bug 721764] souphttpsrc: Add ability to do HTTP session logging

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=721764
  GStreamer | gst-plugins-good | git

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-09 18:25:10 UTC ---
(In reply to comment #7)

> > > Code then will misbehave if G_DISABLE_CHECKS
> > > was set for glib?. Now (!level) is being read from
> > > a writable user facing prop, I'm guessing you didn't
> > > meant to include that one in your "they"?
> > 
> > I did, setting the GObject property to another value will cause a g_critical()
> > and is also considered a programming error. Adding a g_return_if_fail() for
> > that seems ok.
> 
> But 0 is not an invalid prop value. I just don't want
> to attach a logger for GST_SOUP_LOGGER_NONE so the
> g_return_if_fail() wont do any good but harm if
> G_DISABLE_CHECKS. Same for !session and logger.

Oh right, for 0 you can do a normal if indeed :) All the others are programming
errors though

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.