[Bug 720345] videobalance: handle unsupported caps features in passthrough mode

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=720345
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #265868|none                        |needs-work
             status|                            |

--- Comment #11 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-10 08:47:51 UTC ---
Review of attachment 265868:
 --> (https://bugzilla.gnome.org/review?bug=720345&attachment=265868)

No idea about the name, I don't like this one :) Maybe instead of such things
we should somehow check with the allocation query or something if downstream
can do deinterlace or colorbalance and otherwise fail. Like what textoverlay
does.

::: gst/videofilter/gstvideobalance.c
@@ +176,3 @@
+    GstPad *srcpad = GST_BASE_TRANSFORM_SRC_PAD (base);
+    GstCaps *srccaps = gst_pad_get_current_caps (srcpad);
+    if (srccaps) {

Why srccaps? Why not sinkcaps?

@@ +436,3 @@
+  GstStaticCaps static_caps = GST_STATIC_CAPS (VIDEOBALANCE_CAPS);
+
+  caps = gst_caps_new_empty_simple ("video/x-raw");

Maybe make these static caps too so we don't have to create a new caps instance
every time. Also isn't this caps a subset of VIDEOBALANCE_CAPS anyway? Why the
two intersections?

@@ +611,3 @@
           DEFAULT_PROP_SATURATION,
           GST_PARAM_CONTROLLABLE | G_PARAM_READWRITE |
G_PARAM_STATIC_STRINGS));
+  g_object_class_install_property (gobject_class, PROP_BEST_EFFORT_MODE,

Needs a gtk-doc comment, with Since marker and explanation why this is useful

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.