[Bug 721764] souphttpsrc: Add ability to do HTTP session logging

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=721764
  GStreamer | gst-plugins-good | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk

--- Comment #14 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2014-01-10 15:43:01 UTC ---
(In reply to comment #13)
> @@ +77,3 @@
> +
> +  if (!session) {
> +    GST_WARNING_OBJECT (who, "Have no session. Can't attach a logger");
> 
> This seriously needs a g_return_if_fail() as it must not happen. Same goes for
> !element

Should just be a g_assert() if it's a concern. g_return_*() is for public API.
Looking at the callers of this function, it seems like we'll crash much earlier
if session is NULL.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.