[Bug 721835] segment format assertion fails when video decoding

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=721835
  GStreamer | gst-plugins-base | 1.2.2

--- Comment #25 from Aleix Conchillo Flaqué <aleix at oblong.com> 2014-01-11 05:52:13 UTC ---
(In reply to comment #23)
> Created an attachment (id=265987)
 View: https://bugzilla.gnome.org/attachment.cgi?id=265987
 Review: https://bugzilla.gnome.org/review?bug=721835&attachment=265987

> videodecoder: do not lose events when dropping frames
> 
> Finally understood what is possibly happening here.
> 
> 1) after the seek, the videodecoder is flushed
> 2) videodecoder gets a new segment
> 3) videodecoder receives its first buffer and attaches the segment event to it
> 4) avdec_h264 tries to decode this buffer, but it is not a keyframe and it
> can't
>    be decoded, so it skips it
> 5) videodecoder receives more buffers and still can't decode any of those
> buffers
> 6) videodecoder finally gets a keyframe and is now able to decode this buffer,
>    after decoding it, avdec_h264 goes over the list of pending frames and drops
>    those that won't be useful anymore. The segment event is now lost
> 7) assertion!
> 
> Let's hope this is the case. Could you please test this patch?

Yes, this all sounds great. As I mentioned in comment 2 it only happens when
first frames can't be decoded.

I see if I can try it over the weekend but I don't promise anything as my
failing test case is at work.

Thanks for the work!

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.