[Bug 721666] videodecoder: push newsegment earlier for reverse playback

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Jan 13 01:28:48 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=721666
  GStreamer | gst-plugins-base | unspecified

Thiago Sousa Santos <thiago.sousa.santos> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #17 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2014-01-13 09:28:46 UTC ---
Pushed to master

commit b1e728a8540d6aab44d4b7c489120b3acf896385
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Wed Jan 8 11:29:29 2014 -0300

    tests: videodecoder: add test for reverse playback

    Checks that buffers are pushed backwards in reverse playback

    https://bugzilla.gnome.org/show_bug.cgi?id=721666

commit 5b8e1925b566b57b516c76f12610d42e6ad2b791
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Mon Jan 6 20:53:15 2014 -0300

    videodecoder: use new segment earlier for reverse playback

    For reverse playback, the segment event will only be pushed when
    the first buffer is actually pushed. But for decoding frames and storing
    those into the list to be pushed the output_segment.rate value is used
    to determine if it is forward or reverse playback.

    In case a previous segment event (or none) is in use it will mistakenly
    think it is doing forward playback and push the buffers immediatelly and
    try to clip buffers based on an old segment (or an uninitialized one,
leading
    to an assertion)

    This patch fixes this by copying the segment earlier if on reverse playback

    https://bugzilla.gnome.org/show_bug.cgi?id=721666

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list