[Bug 721666] videodecoder: push newsegment earlier for reverse playback

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=721666
  GStreamer | gst-plugins-base | unspecified

--- Comment #20 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2014-01-13 11:22:21 UTC ---
(In reply to comment #16)
> Review of attachment 265913 [details]:
> 
> ::: gst-libs/gst/video/gstvideodecoder.c
> @@ +1968,3 @@
> +        dec->priv->pending_events =
> +            g_list_append (dec->priv->pending_events, event);
> +        frame->events = g_list_delete_link (frame->events, cur);
> 
> Trying to understand the patch.
> 
> Why do we need to move the event from the frame and put it in the pending
> events list?
> 
> Don't they get all pushed in gst_video_decoder_prepare_finish_frame? First, the
> pending events and then the frame events?

For reverse playback, the buffers will be pushed in reverse order, but some
events need to be pushed before any data and they are usually attached to the
first buffer. To be sure that those events are going to be pushed early enough,
move them to the pending events list, so they will be pushed before any of the
buffers.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.