[Bug 720345] videobalance: handle unsupported caps features in passthrough mode

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=720345
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #265929|none                        |reviewed
             status|                            |

--- Comment #17 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-14 09:06:56 UTC ---
Review of attachment 265929:
 --> (https://bugzilla.gnome.org/review?bug=720345&attachment=265929)

Looks generally good but I'm not sure I really like this implementation.

Maybe need a different approach, maybe something with metas that are negotiated
similar to the subtitle stuff.
Or only allow passthrough if all the properties are also on passthrough,
otherwise fail if the video format is not supported.

This all is rather weird and unexpected otherwise. Same goes for deinterlace
IMHO.

::: gst/videofilter/gstvideobalance.c
@@ +614,3 @@
+  * when videobalance is auto-inserted by playbin after an hardware decoder.
+  * In this mode, changing any of the constrat, brightness and saturation
+  * properties won't have any effects.

Since: 1.4

@@ +830,3 @@
       break;
+    case PROP_FALLBACK_TO_PASSTHROUGH:
+      d = g_value_get_boolean (value);

Isn't d a double? ;)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.