[Bug 721764] souphttpsrc: Add ability to do HTTP session logging

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=721764
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #265942|none                        |needs-work
             status|                            |

--- Comment #21 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-14 10:17:49 UTC ---
Review of attachment 265942:
 --> (https://bugzilla.gnome.org/review?bug=721764&attachment=265942)

Squash in the removal of the custom logging

::: ext/soup/gstsouphttpsrc.c
@@ +247,3 @@
           "metadata interleaved with the actual stream data)",
           DEFAULT_IRADIO_MODE, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
+  g_object_class_install_property (gobject_class, PROP_SOUP_LOG_LEVEL,

This should get some gtk-doc chunk with a Since: 1.4

::: ext/soup/gstsouputils.c
@@ +47,3 @@
+       * log level to SoupLoggerLogLevel and it should be added
+       * as a case */
+      c = level;

Erm, no. You must make a printable char out of that :) level + '0' maybe, that
will just do weird things if level is larger than 9.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.