[Bug 722144] audiodecoder: do not negotiate caps with rate=1 and channels=1 for gap

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Jan 14 04:46:59 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=722144
  GStreamer | gst-plugins-base | unspecified

Thiago Sousa Santos <thiago.sousa.santos> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2014-01-14 12:46:55 UTC ---
Thanks for the quick review

commit 8cf8332b91a2caf3b23f711ea1eecd7430a0bfa5
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Mon Jan 13 20:44:23 2014 -0300

    audiodecoder: make sure caps is set before forwarding gap event

    Before trying to generate a default fixated caps when handling a gap
    event, make sure that the same strategy that is used when handling
    a buffer has been attempted. Otherwise audiodecoder will ignore
    upstream caps settings such as rate and channels and will likely
    end with a caps with channels=1 and rate=1.

    https://bugzilla.gnome.org/show_bug.cgi?id=722144

commit bbbd9f7d49ac0635776eba816af08bb533be9ea1
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Mon Jan 13 19:40:49 2014 -0300

    tests: audiodecoder: check that negotiation works buffers and gaps

    Adds 2 tests to verify that output caps are the expected value, reusing
    input structure values for both buffers and gaps

    https://bugzilla.gnome.org/show_bug.cgi?id=722144

commit 755414ed1e6994358dc1c6c24983531e23fe9724
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Mon Jan 13 16:33:11 2014 -0300

    tests: audiodecoder: add basic playback test for audio decoder

    Simple test that just check that audio decoding works as expected

    https://bugzilla.gnome.org/show_bug.cgi?id=722144

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list