[Bug 721384] h264parse: clears keyframe flags when passing through byte-stream AUs (regression)

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=721384
  GStreamer | gst-plugins-bad | git

--- Comment #5 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2014-01-15 05:00:50 UTC ---
When trying to parse the only PPS in the stream, the h264parser lib fails on
the last data to parse:

READ_SE_ALLOWED (&nr, pps->second_chroma_qp_index_offset, -12, 12);

It seems there is only one bit remaining when it gets to this point and this
bit is 0. AFAIK, 0 is not an allowed value for the 'exponential Golomb coding'
that is used in NAL units, so that fails. IIRC a value of 0 should be
represented with a single bit 1.

So the nal_reader_get_ue will return FALSE and the PPS will be discarded.
Without parsing this PPS it makes h264parse unable to set keyframe information
into outgoing buffers.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.