[Bug 722240] h265parser:update caps when receive VPS/SPS

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Jan 15 03:29:08 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=722240
  GStreamer | gst-plugins-bad | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #266338|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-15 11:29:03 UTC ---
Review of attachment 266338:
 --> (https://bugzilla.gnome.org/review?bug=722240&attachment=266338)

In general, can you provide a stream to reproduce these? :)

::: gst-libs/gst/codecparsers/gsth265parser.c
@@ +1757,3 @@
+              vps->cprms_present_flag, vps->max_sub_layers_minus1))
+        goto error;
+    }

Can you put this part into a separate patch?

::: gst/videoparsers/gsth265parse.c
@@ +1835,3 @@
+      /* we did parse codec-data and might supplement src caps */
+      gst_h265_parse_update_src_caps (h265parse, caps);
+    }

After this change you only set the src caps if sps, vps and pps have been
parsed, right? Will we queue all buffers until that is the case?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list