[Bug 722345] directfb: video sink crashes when used with ext_surface

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=722345
  GStreamer | gst-plugins-bad | 1.2.2

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #266478|none                        |needs-work
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-16 16:02:14 UTC ---
Review of attachment 266478:
 --> (https://bugzilla.gnome.org/review?bug=722345&attachment=266478)

:::
/home/etrousset/source_ext/gst-1.2.2/gst-plugins-bad-1.2.2.modified/ext/directfb/dfbvideosink.c
@@ +1125,1 @@
     case GST_VIDEO_FORMAT_RGB:

As said, this looks wrong and the same in the other change. Use things like 
#if G_BYTE_ORDER == G_LITTLE_ENDIAN
blablabla code with BGR
#else
blablabla code with RGB
#endif

Assuming this is really correct with DirectFB. I didn't check that.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.