[Bug 722345] directfb: video sink crashes when used with ext_surface

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=722345
  GStreamer | gst-plugins-bad | 1.2.2

--- Comment #17 from Eric <etrousset at awox.com> 2014-01-17 13:51:31 UTC ---
(In reply to comment #16)
> (In reply to comment #9)
> > Review of attachment 266477 [details] [details]:
> > 
> > Please also provide both patches in "git format-patch" format.
> > 
> > :::
> > /home/etrousset/source_ext/gst-1.2.2/gst-plugins-bad-1.2.2.modified/ext/directfb/dfbvideosink.c
> > @@ +436,3 @@
> > +  if (meta->pixel_format != DSPF_UNKNOWN) {
> > +    alloc_size =
> > +        meta->width * meta->height * DFB_BYTES_PER_PIXEL (meta->pixel_format);
> > 
> > With stride I mean how many bytes are used per row, which is usually not
> > width*bpp but larger than that
> 
> In DirectFB they use the term pitch, see Lock method of Surface, ret_pitch:
> http://directfb.org/docs/DirectFB_Reference_1_7/IDirectFBSurface_Lock.html

yes, but with DFB_BYTES_PER_LINE(meta->pixel_format,
meta->width); we can avoid Lock and Unlocking the surface just to get the
pitch.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.