[Bug 722453] avviddec: add output-corrupt property

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=722453
  GStreamer | gst-libav | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #266576|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-17 20:45:56 UTC ---
Review of attachment 266576:
 --> (https://bugzilla.gnome.org/review?bug=722453&attachment=266576)

Almost good, but please make your commit message more similar to the other ones
and:

::: ext/libav/gstavviddec.c
@@ +47,3 @@
 #define DEFAULT_DEBUG_MV        FALSE
 #define DEFAULT_MAX_THREADS        0
+#define DEFAULT_OUTPUT_CORRUPT TRUE

Please properly indent this

@@ +1850,3 @@
+      ffmpegdec->output_corrupt = g_value_get_boolean (value);
+      gst_ffmpegviddec_context_set_flags (ffmpegdec->context,
+          CODEC_FLAG_OUTPUT_CORRUPT, ffmpegdec->output_corrupt);

You check inside the function if there is a context or not... and do that with
an assertion. But here in set_property you might not have a context yet IIRC

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.