[Bug 722462] New: [PATCH] tsdemux: Fix leak of PCROffsetGroup

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=722462
  GStreamer | gst-plugins-bad | git

           Summary: [PATCH] tsdemux: Fix leak of PCROffsetGroup
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: me at andrey-utkin.pp.ua
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=266588)
 View: https://bugzilla.gnome.org/attachment.cgi?id=266588
 Review: https://bugzilla.gnome.org/review?bug=722462&attachment=266588

patch

How to reproduce:

 $ ffmpeg -loglevel fatal -t 10 -f lavfi -i testsrc -f mpegts - |
G_SLICE=always-malloc valgrind
--suppressions=/usr/local/src/gstreamer/common/gst.supp --show-reachable=no
gst-launch-1.0 filesrc location=/dev/stdin ! tsdemux ! fakesink
==9174== Memcheck, a memory error detector
==9174== Copyright (C) 2002-2012, and GNU GPL'd, by Julian Seward et al.
==9174== Using Valgrind-3.8.1 and LibVEX; rerun with -h for copyright info
==9174== Command: gst-launch-1.0 filesrc location=/dev/stdin ! tsdemux !
fakesink
==9174== 
GStreamer has detected that it is running inside valgrind.
It might now take different code paths to ease debugging.
Of course, this may also lead to different bugs.
Setting pipeline to PAUSED ...
Pipeline is PREROLLING ...
Pipeline is PREROLLED ...
Setting pipeline to PLAYING ...
New clock: GstSystemClock
Got EOS from element "pipeline0".
Execution ended after 0:00:00.276477238
Setting pipeline to PAUSED ...
Setting pipeline to READY ...
Setting pipeline to NULL ...
Freeing pipeline ...
==9174== 
==9174== HEAP SUMMARY:
==9174==     in use at exit: 394,590 bytes in 1,943 blocks
==9174==   total heap usage: 73,890 allocs, 71,947 frees, 7,246,127 bytes
allocated
==9174== 
==9174== 200 (24 direct, 176 indirect) bytes in 1 blocks are definitely lost in
loss record 1,753 of 1,819
==9174==    at 0x4C2C5DB: malloc (vg_replace_malloc.c:270)
==9174==    by 0x591221A: g_malloc (gmem.c:159)
==9174==    by 0x592AC50: g_slice_alloc (gslice.c:1003)
==9174==    by 0x5905FB2: g_list_prepend (glist.c:279)
==9174==    by 0x78B76D2: _insert_group_after (mpegtspacketizer.c:1702)
==9174==    by 0x78B7FB4: _set_current_group (mpegtspacketizer.c:1787)
==9174==    by 0x78B8DFF: record_pcr (mpegtspacketizer.c:1897)
==9174==    by 0x78B0D6E: mpegts_packetizer_parse_adaptation_field_control
(mpegtspacketizer.c:376)
==9174==    by 0x78B1238: mpegts_packetizer_parse_packet
(mpegtspacketizer.c:448)
==9174==    by 0x78B2167: mpegts_packetizer_next_packet
(mpegtspacketizer.c:816)
==9174==    by 0x78C0864: mpegts_base_chain (mpegtsbase.c:1109)
==9174==    by 0x4EB12A4: gst_pad_chain_data_unchecked (gstpad.c:3773)
==9174==    by 0x4EB1F37: gst_pad_push_data (gstpad.c:4006)
==9174==    by 0x4EB2488: gst_pad_push (gstpad.c:4109)
==9174==    by 0x767904F: gst_base_src_loop (gstbasesrc.c:2785)
==9174==    by 0x4EE6047: gst_task_func (gsttask.c:316)
==9174==    by 0x4EE7142: default_func (gsttaskpool.c:70)
==9174==    by 0x59379BD: g_thread_pool_thread_proxy (gthreadpool.c:309)
==9174==    by 0x59373D2: g_thread_proxy (gthread.c:798)
==9174==    by 0x601BDA5: start_thread (in /lib64/libpthread-2.15.so)
==9174== 
==9174== LEAK SUMMARY:
==9174==    definitely lost: 24 bytes in 1 blocks
==9174==    indirectly lost: 176 bytes in 2 blocks
==9174==      possibly lost: 0 bytes in 0 blocks
==9174==    still reachable: 32,188 bytes in 561 blocks
==9174==         suppressed: 362,202 bytes in 1,379 blocks
==9174== Reachable blocks (those to which a pointer was found) are not shown.
==9174== To see them, rerun with: --leak-check=full --show-reachable=yes
==9174== 
==9174== For counts of detected and suppressed errors, rerun with: -v
==9174== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 152 from 152)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.