[Bug 722511] [RFC][PATCH] Introduce tq: tee element with embedded queue elements on srcpads

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=722511
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |slomo at coaxion.net
     Ever Confirmed|0                           |1

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-01-19 09:24:10 UTC ---
Didn't review it yet but I think it might be beneficial to use IDLE probes
here. Should be just an optimization though. Also don't use // comments but /*
*/ :) And when releasing a "tee ! queue" branch you will need to drain it, e.g.
EOS event or DRAIN query. Didn't see anything while looking fast over the code.

(In reply to comment #0)

> The code currently lacks management of inside tee and queues properties. I
> haven't decided yet how exactly they would be passed through, possibly as two
> properties "tee-props" and "queue-props" as strings representing a set of
> key-value pairs.

See the GstChildProxy interface. For the queues it might be good to have
default settings for newly created queues as part of the "tq" element though.

I wouldn't recommend using a generic string property with key-value pairs. Add
a proper property for everything you need.

> P. S. How xml doc is generated?

You add stuff to docs/plugins/Makefile.am and then run "make update-docs". Or
something like that :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.